[CMake] More cleanups to libCling linking #20003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing should access libCling directly, and tests in core/base/ don't seem to use dl* functions directly anymore, so libdl isn't needed either.
... as it was already done on Windows: It uses some symbols and this allows to remove some bad linker options.
hageboeck
approved these changes
Sep 29, 2025
They should not be propagated to targets that link against libCling (which also nobody should do).
ld: warning: -bind_at_load is deprecated on macOS From $ man ld: Sets a bit in the mach header of the resulting binary which tells dyld to bind all symbols when the binary is loaded, rather than lazily. This contradicts the flags RTLD_LAZY|RTLD_LOCAL passed to dlopen when loading libCling, and is different from the behavior on other platforms that don't have this flag, such as Linux. Also remove the warning suppression that was hiding this deprecation message. It was added as part of commit 5ad4ab9 ("[cmake] Silence macOS linker warnings on -undefined dynamic_lookup:"), which we don't use anymore for libCling since the previous commit.
vgvassilev
approved these changes
Sep 29, 2025
pcanal
reviewed
Sep 29, 2025
Test Results 22 files 22 suites 3d 17h 58m 44s ⏱️ Results for commit 85e409d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.