Skip to content

[InterOp] Fix a build failure when configuring offline #20011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

[InterOp] Fix a build failure when configuring offline #20011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c48f506
[InterOp] Fix a build failure on Gentoo.
hageboeck Sep 30, 2025
72b979a
[InterOp] Prevent a configure failure when offline.
hageboeck Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions interpreter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,14 +557,10 @@ set(CPPINTEROP_USE_CLING ON CACHE BOOL "" FORCE)
set(CPPINTEROP_USE_REPL OFF CACHE BOOL "" FORCE)

#---Disable testing on InterOp if ROOT's testing is OFF (InterOp tests are enabled by default) -------------------------------------------------------
ROOT_CHECK_CONNECTION("CPPINTEROP_ENABLE_TESTING=OFF")
if(testing AND NOT NO_CONNECTION)
set(CPPINTEROP_ENABLE_TESTING ON CACHE BOOL "" FORCE)
if(testing)
set(CPPINTEROP_ENABLE_TESTING ON CACHE BOOL "Enable gtest in CppInterOp")
else()
if(NO_CONNECTION)
message(STATUS "No internet connection, disabling the `CppInterOp testing infrastructure` option")
endif()
set(CPPINTEROP_ENABLE_TESTING OFF CACHE BOOL "")
set(CPPINTEROP_ENABLE_TESTING OFF CACHE BOOL "Enable gtest in CppInterOp")
endif()

add_subdirectory(CppInterOp)
Expand Down
6 changes: 5 additions & 1 deletion interpreter/CppInterOp/unittests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ enable_testing()

# LLVM builds (not installed llvm) provides gtest.
if (NOT TARGET GTest::gtest AND NOT TARGET gtest)
include(GoogleTest)
find_package(GTest)
if (NOT GTest_FOUND)
message(WARNING "CppInterOp could not find GTest. Provide the package or set CPPINTEROP_ENABLE_TESTING=OFF to disable this warning.")
return()
endif()
endif()

if(EMSCRIPTEN)
Expand Down
Loading