-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[rfile] Introduce ListKeys() method #20056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 21 files 21 suites 3d 17h 9m 20s ⏱️ For more details on these failures, see this check. Results for commit 75db7dd. ♻️ This comment has been updated with latest results. |
ed31e98 to
a001f6d
Compare
7f3f1db to
d4daafe
Compare
f8d84c1 to
b8cb541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but see extra comments below.
84785ef to
ad5748c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks! But consider the following comments
Followup of #19958. Other than addressing @pcanal's comments, this PR introduces the
ListKeys()method, which iterates over the keys of some subdirectory.They do so via an iterator that returns an abridged version of TKey, currently containing only barebones information (more may be added later).
Checklist: