Skip to content

Conversation

@silverweed
Copy link
Contributor

@silverweed silverweed commented Oct 8, 2025

Followup of #19958. Other than addressing @pcanal's comments, this PR introduces the ListKeys() method, which iterates over the keys of some subdirectory.
They do so via an iterator that returns an abridged version of TKey, currently containing only barebones information (more may be added later).

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results

    21 files      21 suites   3d 17h 9m 20s ⏱️
 3 690 tests  3 689 ✅ 0 💤 1 ❌
75 615 runs  75 613 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 75db7dd.

♻️ This comment has been updated with latest results.

@silverweed silverweed force-pushed the rfile_02 branch 3 times, most recently from ed31e98 to a001f6d Compare October 8, 2025 15:00
@silverweed silverweed changed the title [rfile] Introduce GetKeys() methods [rfile] Introduce ListKeys() method Oct 9, 2025
@silverweed silverweed force-pushed the rfile_02 branch 2 times, most recently from 7f3f1db to d4daafe Compare October 9, 2025 14:18
@silverweed silverweed force-pushed the rfile_02 branch 2 times, most recently from f8d84c1 to b8cb541 Compare October 13, 2025 09:01
@silverweed silverweed added the clean build Ask CI to do non-incremental build on PR label Oct 15, 2025
@silverweed silverweed closed this Oct 15, 2025
@silverweed silverweed reopened this Oct 15, 2025
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but see extra comments below.

@silverweed silverweed force-pushed the rfile_02 branch 3 times, most recently from 84785ef to ad5748c Compare October 15, 2025 13:51
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks! But consider the following comments

@silverweed silverweed merged commit 1c9bfec into root-project:master Oct 22, 2025
22 of 27 checks passed
@silverweed silverweed deleted the rfile_02 branch October 22, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR in:I/O

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants