[io] ROOT::Detail::TKeyMapIterable: return ref in operator++() #20074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 19h 32m 40s ⏱️ For more details on these failures, see this check. Results for commit 01903db. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
tfilemap_iter
branch
from
237c6a9 to
9c1932b
Compare
|
Update: I also changed the iterator tag from Forward to Input (see commit description) |
hahnjo
approved these changes
Oct 20, 2025
Also make the iterator an input_iterator rather than forward_iterator, since it does not satisfy all forward iterator requirements (in particular "f i and j are both dereferenceable, then i == j if and only if *i and *j are bound to the same object.")
silverweed
force-pushed
the
tfilemap_iter
branch
from
9c1932b to
01903db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirements for an iterator mandate that
operator++()returns a reference to the iterator, not a copy.