[gpad] provide methods to use double as pixel coordinates #20123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows convert into pixel coordinates without rounding. It is crucial for different painting when further coordinates calculations are applied and resulted coordinate may differ on different platforms because of used rounding
There are several methods where produced value checked for valid pixel range
Let produce text coordinates more precise
Replace y++ by +1 to be clear with double arithmetic
Replace int by double to let avoid rounding conversion failures
While for small fonts such rounding can have significant drawback
Define generic `Rotate` method to rotate N points Provide specialization for single point Use `TVirtualPad *` in arguments to making first step out of using of global pad pointer in painter.
couet
approved these changes
Oct 16, 2025
in stressGraphics.ref and roottest/root/treedraw/hsimple.ps.ref
Test Results 22 files 22 suites 3d 20h 8m 21s ⏱️ For more details on these failures, see this check. Results for commit ca8f9cd. |
|
All failed tests do not use graphics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion methods to/from pixel in TVirtualPad now provided with double
Use these methods in TLatex for transformation. Especially due to rotation double precision let keep original coordiantes