Split ROOT-10804 test into several runs: #552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phsft-bot build! |
|
@phsft-bot build |
Once autoparsing happened, everything can be resolved. Make sure we test what is supposed to be tested, namely early-registration alternate names. To do that, test only one class name per test run.
Axel-Naumann
force-pushed
the
ROOT-10804-split
branch
from
fcf37db to
264e4ef
Compare
pcanal
reviewed
Mar 18, 2021
| list(LENGTH CLASSES_TO_TEST LEN_CLASSES_TO_TEST) | ||
| math(EXPR LAST_CLASS_TO_TEST ${LEN_CLASSES_TO_TEST}-1) | ||
| # foreach takes *last*, not num-elements :-( | ||
| foreach(INDEX RANGE ${LAST_CLASS_TO_TEST}) |
There was a problem hiding this comment.
Isn't 'foreach element of the list'? If there is and it does not work, could you add a comment why not?
pcanal
approved these changes
Mar 18, 2021
|
@phsft-bot build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once autoparsing happened, everything can be resolved.
Make sure we test what is supposed to be tested, namely
early-registration alternate names. To do that, test only
one class name per test run.