Build tags omit network drivers #533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
force-pushed
the
build-tags-omit-network-drivers
branch
2 times, most recently
from
b123542 to
95cf9e5
Compare
AkihiroSuda
reviewed
Oct 10, 2025
| The child command can enter `$ROOTLESSKIT_STATE_DIR/netns` by itself to create nested network namespaces. | ||
|
|
||
|
|
||
| ## Build tags to omit drivers |
There was a problem hiding this comment.
This should be probably in /BUILDING.md
AkihiroSuda
reviewed
Oct 10, 2025
docs/network.md
Outdated
| go build -tags no_slirp4netns ./cmd/rootlesskit | ||
|
|
||
| - Build without lxc-user-nic support: | ||
| go build -tags no_lxcusernic ./cmd/rootlesskit |
There was a problem hiding this comment.
Only one example should suffice for a document.
The CI should test all of them, and a combination of them too.
There was a problem hiding this comment.
fixed, but I what to test here ?
There was a problem hiding this comment.
Just test go build with several combination s of the tags
There was a problem hiding this comment.
I added some tests
AkihiroSuda
reviewed
Oct 10, 2025
|
|
||
| // NewParentDriver returns a stub when built with the no_gvisortapvsock tag. | ||
| func NewParentDriver(logWriter io.Writer, mtu int, ipnet *net.IPNet, ifname string, disableHostLoopback bool, enableIPv6 bool) (network.ParentDriver, error) { | ||
| return &disabledParent{}, errors.New("gvisor-tap-vsock network driver disabled by build tag no_gvisortapvsock") |
There was a problem hiding this comment.
Omitted drivers should not appear in --help
fahedouch
force-pushed
the
build-tags-omit-network-drivers
branch
from
4c89ecd to
e13e7de
Compare
Signed-off-by: fahed dorgaa <[email protected]>
fahedouch
force-pushed
the
build-tags-omit-network-drivers
branch
from
4e968b8 to
a91432a
Compare
|
@AkihiroSuda PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.