Skip to content

Conversation

@llrs
Copy link
Member

@llrs llrs commented Nov 10, 2024

The last sentence of maintenance_evolution repeated something on the check-list with a different organization name. I think it can be removed to avoid confusion.

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @llrs !

@mpadge
Copy link
Member

mpadge commented Nov 11, 2024

@maelle I have approved; can you please merge? Merci!

@maelle
Copy link
Member

maelle commented Nov 12, 2024

I'll try to come back to this PR soon. I need to update the Spanish file and Portuguese PR if it exists.

@maelle
Copy link
Member

maelle commented Nov 22, 2024

I don't think the sentence is actually incorrect: if a package is unarchived from ropensci-archive it should go to ropenscilabs (sometimes it goes to ropensci but it's a mistake 😅 ).

@llrs
Copy link
Member Author

llrs commented Nov 22, 2024

Oh, sorry, I thought it would go back to the ropensci repository if fit. Does it go to ropenscilab first to ensure it is up to rOpenSci standards?

@maelle
Copy link
Member

maelle commented Dec 2, 2024

Yes in theory at least that was the idea.

@mpadge any comment?

@mpadge
Copy link
Member

mpadge commented Dec 2, 2024

I think removing that sentence is good. As far as I'm aware, there haven't even been any unarchived packages for ... years. And going by the unused = unnecessary principle, this removes cruft from the dev guide, so 👍

maelle added a commit that referenced this pull request Feb 3, 2025
@maelle
Copy link
Member

maelle commented Feb 3, 2025

Thanks again and sorry for the delay!

@maelle maelle merged commit 0ece97c into ropensci:main Feb 3, 2025
1 check failed
maelle added a commit that referenced this pull request Mar 27, 2025
* add translation

* Apply suggestions from code review

Co-authored-by: Rafael Fontenelle <[email protected]>

* Apply suggestions from code review

Co-authored-by: Rafael Fontenelle <[email protected]>

* align with #849

* Update maintenance_evolution.pt.Rmd

Co-authored-by: Rafael Fontenelle <[email protected]>

---------

Co-authored-by: Maëlle Salmon <[email protected]>
Co-authored-by: Rafael Fontenelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants