-
Notifications
You must be signed in to change notification settings - Fork 67
Remove incorrect sentence #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mpadge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @llrs !
|
@maelle I have approved; can you please merge? Merci! |
|
I'll try to come back to this PR soon. I need to update the Spanish file and Portuguese PR if it exists. |
|
I don't think the sentence is actually incorrect: if a package is unarchived from ropensci-archive it should go to ropenscilabs (sometimes it goes to ropensci but it's a mistake 😅 ). |
|
Oh, sorry, I thought it would go back to the ropensci repository if fit. Does it go to ropenscilab first to ensure it is up to rOpenSci standards? |
|
Yes in theory at least that was the idea. @mpadge any comment? |
|
I think removing that sentence is good. As far as I'm aware, there haven't even been any unarchived packages for ... years. And going by the unused = unnecessary principle, this removes cruft from the dev guide, so 👍 |
|
Thanks again and sorry for the delay! |
* add translation * Apply suggestions from code review Co-authored-by: Rafael Fontenelle <[email protected]> * Apply suggestions from code review Co-authored-by: Rafael Fontenelle <[email protected]> * align with #849 * Update maintenance_evolution.pt.Rmd Co-authored-by: Rafael Fontenelle <[email protected]> --------- Co-authored-by: Maëlle Salmon <[email protected]> Co-authored-by: Rafael Fontenelle <[email protected]>
The last sentence of maintenance_evolution repeated something on the check-list with a different organization name. I think it can be removed to avoid confusion.