Review 2 of Softwarereview_reviewer.pt.Rmd-pt-auto

[samuel-carleial]

@pedropark99
Here is my R2 to this task. I had a detailed look on the english version to the side, and tried to improve the PT-BR translation. Espero que tenha melhorado.

[samuel-carleial]

Should the PR be actually to the working branch? Did I do something wrong here?

[pedropark99]

@samuel-carleial Yes! This PR should aim to the working branch, instead of targeting the main branch.

Therefore, the target branch should be ropensci:softwarereview_reviewer.pt.Rmd-pt-auto

[samuel-carleial]

Ok eu vou tentar fazer direto depois. Obrigado pela resposta

…

On Tue, 26 Nov 2024, 21:57 Pedro Faria, ***@***.***> wrote: @samuel-carleial <https://github.com/samuel-carleial> Yes! This PR should aim to the working branch, instead of targeting the main branch. Therefore, the target branch should be ropensci:softwarereview_reviewer.pt.Rmd-pt-auto — Reply to this email directly, view it on GitHub <#853 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ4V64NDNSKIITCUEWHYAST2CTOFFAVCNFSM6AAAAABSRKK4EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRHEZDCMJUGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[yabellini]

@samuel-carleial Here are instructions on how to change the target branch: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request

I can also make the change; let me know. Thank you for the review!

[maelle]

What's the status of this PR? I'm asking because of #893 that edits this file in English, I'm wondering where I should port the changes, and this depends whether this PR is still under review or ready to be merged. 😸

[pedropark99]

@maelle I think this PR should actually be dropped/abandoned. Because the 2 reviews of this specific file were made at another PR #851

[yabellini]

Actually we had to see if any of the suggestions of this PR had to be applied to the guide.
While we were learning how to use git and github during the traslaton it happened that two people reviewed the same PR. We merged the other one because it was done on the PR and was more easy to merge.
I didn't close this one in case some of the suggestions here were useful for the content and we honor the work that was done in this review by taking it into account.

[yabellini]

I have already checked this PR and applied some of the suggestions to the other PR. Closing it now. Thanks, @samuel-carleial and @pedropark99, for all your work on this review.