default branch should not be "master" #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpadge
requested changes
Feb 3, 2025
Member
mpadge
left a comment
mpadge
left a comment
There was a problem hiding this comment.
I personally don't think we should demand that people use "main", but simply that they do not use "master". Happy to discuss if you have other opinions 😄
Co-authored-by: mark padgham <[email protected]>
Member
Author
|
Right, the default is always easier but not compulsory 😸 |
mpadge
approved these changes
Feb 3, 2025
helske
approved these changes
Feb 13, 2025
yabellini
reviewed
Feb 25, 2025
yabellini
approved these changes
Feb 25, 2025
mpadge
changed the title
Member
|
@maelle Note that I just renamed the PR, for reasons that I trust are clear here. |
Co-authored-by: Yanina Bellini Saibene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs