Skip to content

Conversation

@maelle
Copy link
Member

@maelle maelle commented Feb 3, 2025

Fix #780

@yabellini do you agree it is enough to link to the post as opposed to reproducing its content in the chapter? I'm on the fence. Once we make a decision I'll update the other languages

@yabellini
Copy link
Member

This looks great! Thanks!

Copy link
Member

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maelle I just saw that the line 23 said: " - Post about it on social media." that repeat the content in line 17. So we can remove line 23.

@maelle maelle marked this pull request as ready for review February 28, 2025 08:34
@maelle maelle requested a review from yabellini February 28, 2025 08:34
@maelle
Copy link
Member Author

maelle commented Feb 28, 2025

@beatrizmilz, would you have time to review this small change to the Portuguese translation? No worries if not.

@beatrizmilz
Copy link
Contributor

@beatrizmilz, would you have time to review this small change to the Portuguese translation? No worries if not.

Yes! I added some suggestions as comments.

@yabellini
Copy link
Member

Thanks so much @beatrizmilz 🙏

@beatrizmilz
Copy link
Contributor

Thanks so much @beatrizmilz 🙏

You are welcome, Yani!

@maelle
Copy link
Member Author

maelle commented Mar 7, 2025

Thank you @beatrizmilz!!

@maelle maelle merged commit c891349 into main Mar 7, 2025
1 check failed
@mpadge mpadge deleted the marketing branch March 7, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marketing your package

4 participants