-
Notifications
You must be signed in to change notification settings - Fork 90
Expand RealtimeBoxBestEffort #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand RealtimeBoxBestEffort #454
Conversation
|
@bjin2364, all pull requests must be targeted towards the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## humble #454 +/- ##
=======================================
Coverage 69.66% 69.66%
=======================================
Files 10 10
Lines 511 511
Branches 223 223
=======================================
Hits 356 356
Misses 101 101
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good to me 👌🏽👌🏽
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjin2364 can you please cherry-pick this on master branch, and change the base branch of this PR? we can then backport this to the other distros.
|
@christophfroehlich I don't think we need to cherry-pick to |
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I haven't looked into details before, the code diverged quite a lot from humble to newer distros. I'm happy to merge this into humble, could you still have a look if the improvements of the tests can be applied to the master branch? Thanks!
Changes
RealtimeBoxBestEffortcan be used with priority mutexes inmutex.hppTests