Skip to content

Conversation

@bjin2364
Copy link

Changes

  • Removes the static assertion so that RealtimeBoxBestEffort can be used with priority mutexes in mutex.hpp

Tests

  • type parameterized unit tests

@mergify
Copy link

mergify bot commented Nov 13, 2025

@bjin2364, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.66%. Comparing base (d97448d) to head (d81ebba).
⚠️ Report is 2 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble     #454   +/-   ##
=======================================
  Coverage   69.66%   69.66%           
=======================================
  Files          10       10           
  Lines         511      511           
  Branches      223      223           
=======================================
  Hits          356      356           
  Misses        101      101           
  Partials       54       54           
Flag Coverage Δ
unittests 69.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nclude/realtime_tools/realtime_box_best_effort.hpp 84.21% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

saikishor
saikishor previously approved these changes Nov 15, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good to me 👌🏽👌🏽

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjin2364 can you please cherry-pick this on master branch, and change the base branch of this PR? we can then backport this to the other distros.

@saikishor saikishor dismissed their stale review November 15, 2025 20:41

Missing the head branch on rolling

@bjin2364
Copy link
Author

@christophfroehlich I don't think we need to cherry-pick to master branch because master already supports this: https://github.com/ros-controls/realtime_tools/blob/master/realtime_tools/include/realtime_tools/realtime_thread_safe_box.hpp#L69

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I haven't looked into details before, the code diverged quite a lot from humble to newer distros. I'm happy to merge this into humble, could you still have a look if the improvements of the tests can be applied to the master branch? Thanks!

@christophfroehlich christophfroehlich merged commit b96a7f8 into ros-controls:humble Nov 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Priority Inheriting Mutex in RealtimeBoxBestEffort

4 participants