Skip to content

Struct attrributes#268

Draft
yfukai wants to merge 17 commits intoroyerlab:mainfrom
yfukai:struct_attr
Draft

Struct attrributes#268
yfukai wants to merge 17 commits intoroyerlab:mainfrom
yfukai:struct_attr

Conversation

@yfukai
Copy link
Contributor

@yfukai yfukai commented Feb 20, 2026

Partially solves #194 by allowing pl.Struct saved and searched in graphs.
Assumes #262 merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 74.14248% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.96%. Comparing base (e10d8c3) to head (4af9904).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tracksdata/graph/_sql_graph.py 78.57% 20 Missing and 13 partials ⚠️
src/tracksdata/graph/_base_graph.py 70.58% 18 Missing and 2 partials ⚠️
src/tracksdata/utils/_dtypes.py 72.60% 11 Missing and 9 partials ⚠️
src/tracksdata/attrs.py 72.72% 10 Missing and 2 partials ⚠️
src/tracksdata/graph/_rustworkx_graph.py 56.52% 8 Missing and 2 partials ⚠️
src/tracksdata/graph/_graph_view.py 66.66% 2 Missing ⚠️
src/tracksdata/nodes/_regionprops.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   88.18%   86.96%   -1.22%     
==========================================
  Files          56       56              
  Lines        4308     4665     +357     
  Branches      749      816      +67     
==========================================
+ Hits         3799     4057     +258     
- Misses        319      391      +72     
- Partials      190      217      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yfukai yfukai marked this pull request as ready for review February 26, 2026 02:51
@yfukai yfukai mentioned this pull request Feb 26, 2026
8 tasks
@yfukai yfukai marked this pull request as draft February 26, 2026 03:14
@yfukai
Copy link
Contributor Author

yfukai commented Feb 26, 2026

Maybe I should save the data field-wise in SQLGraph. Let me experiment in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants