Fix rename_table for compatibility migrations #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to rails/rails#45136 |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jun 13, 2025
…ompat Fix rename_table for compatibility migrations
yahonda
added a commit
that referenced
this pull request
Jun 13, 2025
Merge pull request #2418 from michael-smith-nz/fix_rename_table_compat
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jun 23, 2025
This commit suppresses the following migration standard output.
```ruby
$ bundle exec rspec spec/active_record/connection_adapters/oracle_enhanced/compatibility_spec.rb:21
==> Loading config from ENV or use default
==> Running specs with ruby version 3.4.4
==> Effective ActiveRecord version 8.0.2
Run options: include {locations: {"./spec/active_record/connection_adapters/oracle_enhanced/compatibility_spec.rb" => [21]}}
== : migrating ===============================================================
-- rename_table(:test_employees, :new_test_employees)
-> 0.2045s
== : migrated (0.2045s) ======================================================
== : reverting ===============================================================
-- rename_table(:new_test_employees, :test_employees)
-> 0.2033s
== : reverted (0.2046s) ======================================================
.
Finished in 0.68775 seconds (files took 0.34644 seconds to load)
1 example, 0 failures
$
```
Follow up rsim#2418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This PR fixes the
ArgumentError: wrong number of arguments (given 3, expected 2)issue when callingrename_tablewith the migration version 7.0 and below.It looks like ActiveRecord is expecting
rename_tableto includeoptionsas a parameter when callingsuperhere