Add support for Ruby 3.4.0 #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents test error such as:
~~~cucumber
Scenario: specify a method does not throw an expection # features/its.feature:145
Given a file named "example_spec.rb" with: # aruba-2.2.0/lib/aruba/cucumber/file.rb:26
"""
class Klass; end
describe Klass do
subject { Klass.new }
its(:foo) { will_not raise_error }
end
"""
When I run rspec # features/step_definitions/additional_cli_steps.rb:1
Then the example should fail # features/step_definitions/additional_cli_steps.rb:23
And the output should contain "Failure/Error: its(:foo) { will_not raise_error }" # aruba-2.2.0/lib/aruba/cucumber/command.rb:123
And the output should contain "expected no Exception, got #<NoMethodError: undefined method `foo'" # aruba-2.2.0/lib/aruba/cucumber/command.rb:123
expected "F\n\nFailures:\n\n 1) Klass foo is expected not to raise Exception\n Failure/Error: its(:foo) {...e\n\nFailed examples:\n\nrspec ./example_spec.rb:5 # Klass foo is expected not to raise Exception\n" to string includes: "expected no Exception, got #<NoMethodError: undefined method `foo'"
Diff:
@@ -1,17 +1,33 @@
-expected no Exception, got #<NoMethodError: undefined method `foo'
+F
+
+Failures:
+
+ 1) Klass foo is expected not to raise Exception
+ Failure/Error: its(:foo) { will_not raise_error }
+
+ expected no Exception, got #<NoMethodError: undefined method 'foo' for an instance of Klass> with backtrace:
+ # ./example_spec.rb:5:in 'block (2 levels) in <top (required)>'
+ # ./example_spec.rb:5:in 'block (2 levels) in <top (required)>'
+
+Finished in 0.01104 seconds (files took 0.05894 seconds to load)
+1 example, 1 failure
+
+Failed examples:
+
+rspec ./example_spec.rb:5 # Klass foo is expected not to raise Exception
(RSpec::Expectations::ExpectationNotMetError)
<internal:array>:42:in 'Array#each'
features/its.feature:158:in `the output should contain "expected no Exception, got #<NoMethodError: undefined method `foo'"'
~~~
Ruby upstream ticket:
https://bugs.ruby-lang.org/issues/16495
Ruby 3.4 replaces initial backtick by single quote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.