fix(tee): prevent panic on UTF-8 multi-byte truncation boundary#1072
Open
pszymkowiak wants to merge 1 commit intodevelopfrom
Open
fix(tee): prevent panic on UTF-8 multi-byte truncation boundary#1072pszymkowiak wants to merge 1 commit intodevelopfrom
pszymkowiak wants to merge 1 commit intodevelopfrom
Conversation
&raw[..max_file_size] panics if the byte offset falls inside a multi-byte UTF-8 character (e.g. Japanese, emoji). Now finds the nearest char boundary before slicing. Ref: issue #640 (L-3 finding) Signed-off-by: Patrick Szymkowiak <patrick@rtk-ai.app> Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&raw[..max_file_size]inwrite_tee_filepanics if the byte offset falls inside a multi-byte UTF-8 character (Japanese, emoji, etc.)char_indices()to find the nearest safe boundary before slicingRef: #640 (L-3 finding from security audit)
Test plan
test_write_tee_file_truncation_utf8_boundary— 3-byte Japanese chars, cut at 998/999test_write_tee_file_truncation_emoji— 4-byte emoji, cut at 201/400