fix(cursor): handle exit code 3 in rtk-rewrite.sh#1100
Open
CamilleGuillory wants to merge 1 commit intortk-ai:developfrom
Open
fix(cursor): handle exit code 3 in rtk-rewrite.sh#1100CamilleGuillory wants to merge 1 commit intortk-ai:developfrom
CamilleGuillory wants to merge 1 commit intortk-ai:developfrom
Conversation
|
|
Made-with: Cursor
CamilleGuillory
force-pushed
the
fix-cursor-hook-exit-code-3
branch
from
afc340e to
bdf123e
Compare
|
that's duplicate of #1075 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1099
The Cursor
rtk-rewrite.shhook was failing to rewrite commands becausertk rewriteexits with code3by default (when no explicit allow/deny rules are matched). The hook script was using|| { echo '{}'; exit 0; }, which caused it to abort on any non-zero exit code.This PR updates the Cursor hook to explicitly handle exit code
3(Ask/Default) and exit code0(Allow) as successful rewrites, while ignoring exit codes1(No RTK equivalent) and2(Deny rule matched), similar to how the Claude Code hook handles it.