Skip to content

fix(dotnet): stop prepending raw stdout on build failure (#914)#1115

Open
ousamabenyounes wants to merge 4 commits intortk-ai:developfrom
ousamabenyounes:fix/issue-914
Open

fix(dotnet): stop prepending raw stdout on build failure (#914)#1115
ousamabenyounes wants to merge 4 commits intortk-ai:developfrom
ousamabenyounes:fix/issue-914

Conversation

@ousamabenyounes
Copy link
Copy Markdown
Contributor

Summary

Fixes #914

  • On dotnet build failure, RTK was prepending the full raw stdout before the filtered summary — producing more tokens than the original command
  • The filtered summary from format_build_output already contains all errors and warnings; the raw output is redundant
  • On success, only the filtered summary was shown (correct). This fix makes failure consistent with success

Verification

  • Baseline tests: 1350 pass, 0 pre-existing failures
  • Post-fix tests: 1351 pass, 0 regressions
  • New test: test_format_build_output_on_failure_is_more_concise_than_raw verifies ≥60% token savings and error info preserved
  • Review agent: issue alignment verified

Files changed

File Change
src/cmds/dotnet/dotnet_cmd.rs Remove raw-prepend block on failure; always use filtered; add savings test

Generated by Claude Code
Vibe coded by ousamabenyounes

aeppling and others added 4 commits April 6, 2026 12:54
feat(): batch fixs + aws extended + filter quality batch
…master--components--rtk

chore(master): release 0.35.0
When dotnet build failed, rtk prepended the full raw output before its
filtered summary, producing more tokens than the original command.
The filtered summary already contains all errors; raw output is not needed.

Generated by Claude Code
Vibe coded by ousamabenyounes

Co-Authored-By: Claude <noreply@anthropic.com>
@ousamabenyounes ousamabenyounes changed the base branch from master to develop April 10, 2026 08:51
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ aeppling
✅ ousamabenyounes
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet build can be more noisy with rtk

3 participants