feat(init): complete Copilot lifecycle - uninstall, idempotency, show_config

[jeziellopes]

Context

PR #859 (merged) shipped a basic --copilot flag from PR #824. This PR completes what was shipped — adding the full agent lifecycle that every other agent in rtk has.

Upstream's current run_copilot() installs files and exits. No idempotency. No uninstall. rtk init --show is blind to Copilot files. This PR fills all of those gaps.

What this adds on top of what shipped

Feature	--copilot (upstream, merged)	--agent copilot (this PR)
Installs .github/ files	✅	✅
Enum pattern (--agent copilot)	❌ standalone --copilot: bool	✅ consistent with --agent cline/windsurf/cursor
Idempotency	❌ always re-runs	✅ early-return with clear status message
PATH check for rtk binary	❌ none	✅ utils::tool_exists() — cross-platform, no false positives on Windows
--uninstall --agent copilot	❌ no uninstall path exists	✅ strips RTK section, preserves pre-existing user content
rtk init --show Copilot status	❌ show_config() has no Copilot awareness	✅ [ok]/[--] for both .github/ files
Unit tests	0	6 new tests

Also fixes #836 / supersedes #837

Issue #836 reports that users who ran rtk init --copilot early on got .github/hooks/rtk-rewrite.json with "command": "rtk hook" (missing subcommand), causing a parse_failure entry on every Bash tool call.

• This PR's uninstall path removes the broken file cleanly
• This PR's show_config() exposes the Copilot files so users can inspect/verify the state
• PR fix(init): detect and clean up orphaned .github/hooks/rtk-rewrite.json with broken hook command #837 (also open, targets same bug) adds orphaned hook detection to --show and --uninstall; this PR's broader lifecycle support already covers that surface

Changes

File	Change
src/main.rs	AgentTarget::Copilot enum variant; "hook" added to RTK_META_COMMANDS; routing to run_copilot_mode()
src/hooks/init.rs	run_copilot_mode() (idempotent install), full uninstall branch (content-safe), show_config() checks, 6 unit tests
.github/hooks/rtk-rewrite.json	"rtk hook" → "rtk hook copilot" (embedded via include_str!, single source of truth)
CHANGELOG.md	[Unreleased] entries

# Install (project-scoped, idempotent)
rtk init --agent copilot
# → .github/hooks/rtk-rewrite.json  (PreToolUse hook)
# → .github/copilot-instructions.md (RTK usage rules)

# Uninstall (strips RTK section, preserves pre-existing user content)
rtk init --uninstall --agent copilot

# Check status
rtk init --show

Testing

✅ cargo fmt --all
✅ cargo clippy --all-targets (0 warnings)
✅ 1129 tests passed (6 new Copilot tests)
✅ Manual: install → idempotent re-run → uninstall → content preserved — all verified

[CLAassistant]

All committers have signed the CLA.

[jeziellopes]

Updated PR to address review gaps and align with issue #823:

Changes in this force-push:

• Switched from hooks/copilot-rtk-rules.md (new file) to hooks/copilot-rtk-awareness.md (existing file, as specified in feat: rtk init --agent copilot (automated Copilot VS Code + CLI setup) #823)
• Added PATH verification: warns if rtk binary not in $PATH
• Added -g flag guard: warns that Copilot setup is always project-scoped
• Improved idempotent messaging: single "RTK already configured for GitHub Copilot" + early return (matching Cline/Windsurf pattern)
• Added show_config() status checks: [ok]/[--] for .github/hooks/rtk-rewrite.json and .github/copilot-instructions.md
• Added rtk init --agent copilot to show_config() Usage block

Additional fixes (self-review, commit 37ebc24):

• Fixed cross-platform PATH check: replaced which (Unix-only) with crate::utils::tool_exists() — no false-positive warnings on Windows
• Fixed uninstall data loss: now strips only the RTK section from copilot-instructions.md instead of deleting the whole file; preserves pre-existing user content
• Added test_uninstall_copilot_preserves_user_content to cover the data-loss scenario
• All 1120 tests pass

Note on #824: PR #824 uses --copilot flag; this PR uses --agent copilot as specified in #823 (consistent with existing --agent cline/--agent windsurf pattern). Happy to align if you prefer one form.

[aeppling]

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

[jeziellopes]

Rebased onto develop after PR #826 (src/ reorganization).

Changes to accommodate the new folder structure:

• src/init.rs → src/hooks/init.rs (auto-merged cleanly by git)
• include_str! paths updated: ../hooks/copilot-rtk-awareness.md → ../../hooks/copilot/rtk-awareness.md, and similarly for the hook JSON
• crate::utils::tool_exists → use crate::core::utils import added (utils moved to src/core/utils.rs)
• All routing in src/main.rs already used hooks::init:: prefix — no changes needed there

1129 tests pass, 0 clippy errors.

[jeziellopes]

Hi @aeppling, rebased and CI-clean after the #826 refactor. I'm actively using GitHub Copilot CLI day-to-day and this is a missing piece for me. Waiting for a review on it. Thanks!

[jeziellopes]

Re: #836 and #837

PR #837 (rolf-quadra) targets the orphaned .github/hooks/rtk-rewrite.json bug from #836 — "command": "rtk hook" (missing subcommand) causes a parse_failure on every Bash tool call.

This PR already covers that surface:

• --uninstall --agent copilot removes .github/hooks/rtk-rewrite.json cleanly
• rtk init --show will expose the Copilot files so users can inspect/verify state

Merging this PR resolves the scenario described in #836 and makes #837 redundant. Flagging in case it helps triage both together.

[jeziellopes]

@aeppling — updated PR description to reflect the current landscape.

Since #859 shipped, the gap is clearer now: upstream has install but no lifecycle — no idempotency, no uninstall, no rtk init --show awareness for Copilot. This PR fills all of that, plus fixes the "rtk hook" bug that's causing spurious parse_failure entries in #836 (which #837 is also trying to fix).

Happy to discuss scope or split if preferred. Thanks!