Add recommendation to avoid variable reflection methods#973
Open
andyw8 wants to merge 1 commit intorubocop:masterfrom
Open
Add recommendation to avoid variable reflection methods#973andyw8 wants to merge 1 commit intorubocop:masterfrom
andyw8 wants to merge 1 commit intorubocop:masterfrom
Conversation
Adds guidance to avoid instance_variable_get, instance_variable_set, and related reflection methods as they break encapsulation. Includes note about acceptable use cases in framework/library code. Planning to add a new RuboCop cop to enforce this guideline. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new guideline recommending against the use of Ruby's variable reflection methods (
instance_variable_get,instance_variable_set, and related methods) as they break encapsulation.Context
I'm planning to add a new RuboCop cop to enforce this guideline. My motivation is that I often see AI agents use these methods instead of fixing the design.
🤖 Generated with Claude Code