Skip to content

Conversation

@vsim95
Copy link

@vsim95 vsim95 commented Dec 18, 2025

BuiltByAI is a "Taskmanmode" developed for my upcoming youtube series I am making around it. I want it to be on the repo for easier use for myself in streaming / recording as well as have the community engagement. Imagine "Player VS AI" where the further progressed your account is, the harsher the AI is. It's not just assigning tasks, but also looking to create your downfall as the player, giving cursed tasks, timed tasks, PVP tasks, curses from the AI for losing, and much more. Complete collection log, combat achievements, PVP tasks, diaries, gear collections, skilling, pet grinds, bossing, raids, and so much more, all assigned to you by the AI overlord NEXUS who wants to see your failure.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 18, 2025

@runelite-github-app
Copy link

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@vsim95
Copy link
Author

vsim95 commented Dec 18, 2025

Guys this is a massive plugin with a ton of code please don't just ignore it - tell me if we can discuss or need anything additional, I am happy to help to get this approved.

@Felanbird
Copy link
Contributor

It's been 24 minutes.

@vsim95
Copy link
Author

vsim95 commented Dec 18, 2025

Felan - I'm not rushing anyone if it came off that way - simply stating I know it's a large project and I am here and happy to help weather that's in 24 hours or a week - Don't take it that way please :)

It's been 24 minutes.

@riktenx
Copy link
Member

riktenx commented Dec 24, 2025

Incomplete review: your runOnClientThread and invokeOnClientThread don't really make any sense. ClientThread::invoke, ClientThread::invokeLater, and SwingUtilities::invokeLater should be all you need here. FYI stuff you queue on client thread in the former APIs runs every client tick (50 client ticks per second), the weird wait-and-interrupt thing is just not necessary and only complicates things. This thread interrupt stuff is not okay at all really, the way you're doing it it's liable to be called on the EDT which would be a problem.

More broadly: This plugin is literally 9000 lines of code and this is not something I'd be able to comprehensively review in the normal "new-plugin" queue, if at all

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added size-0 waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants