Clean up the node manifest
#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using multiple lines makes the dependency seem a bit noisy to me. Put the `minreq` build-dependency on a single line.
The `anyhow` dependency is only used if `download` is enabled, same as all the other optional `build-dependencies`.
tcharding
force-pushed
the
02-06-node-deps
branch
from
b18be99 to
9ead0fa
Compare
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
9ead0fa4dfa4bb2045ed4551c9551a4d01f8da5e Make anyhow an optional build-dependency (Tobin C. Harding)
401684308e083d6838a4497088b7e03ac32792bc Put dep on single line (Tobin C. Harding)
Pull request description:
Quick cleanup to the `node` manifest. Done while working on #53
ACKs for top commit:
apoelstra:
ACK 9ead0fa4dfa4bb2045ed4551c9551a4d01f8da5e; successfully ran local tests
Tree-SHA512: d5556518779eae439858c656583a426b36d2d96753c21157955564d67482bfd251696498417b8a8e21d95f87e07dd71b9b3770f5dc4fb27679097c57f929c2b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick cleanup to the
nodemanifest. Done while working on #53