Fix small typos in ci README #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
Sep 9, 2024
apoelstra
approved these changes
Sep 9, 2024
Member
|
Interesting. I definitely only ran the |
tcharding
reviewed
Nov 4, 2024
ci/README.md
Outdated
| - name: Read nightly version | ||
| id: read_toolchain | ||
| run: echo "nightly_version=$(cat nightly-version)" >> $GITHUB_OUTPUT | ||
| run: echo "nightly_version=$(cat nightly_version)" >> $GITHUB_OUTPUT |
Member
There was a problem hiding this comment.
This is wrong, the file is called nightly-version.
Contributor
Author
There was a problem hiding this comment.
Ok then line 181 must be wrong. I'll change it.
rust-bitcoin-maintainer-tools/ci/README.md
Line 181 in 4f17a05
Member
|
Thanks man, can you squash into a single commit please. |
Contributor
Author
For sure! |
tcharding
approved these changes
Nov 7, 2024
Member
|
Thanks man! |
apoelstra
approved these changes
Nov 7, 2024
apoelstra
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the README trying to add the
rust-bitcoinCI to my BIP-322 crate and found some small things I needed to change to make it work for me.