feat: Improve errors from try_deserialize #695
Merged
+19
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables user code to handle missing and invalid fields after calling try_deserialize instead of having to match and search in the string returned in
ConfigError::Message
.Personally I deem the
String::leak
call safe for my usage, as I would expect to terminate my program on configuration errors anyhow, however we could certainly also change theexpected
field to be aCow<str>
or similar to handle both&'static str
andString
elegantly.Part of #532