Use a RefCell to provide interior mutability for VolumeManager. #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannic
previously approved these changes
Oct 11, 2024
Contributor
jannic
left a comment
jannic
left a comment
There was a problem hiding this comment.
I'd prefer the change to try_borrow_mut, unless I'm missing some reason why that wouldn't be easily possible.
Otherwise, LGTM.
thejpster
force-pushed
the
interior-mutability
branch
from
22fc45b to
0abc8ef
Compare
Member
Author
|
I rebased. |
Member
Author
|
Rust is brilliant. I had very little trouble chopping up this codebase and hacking on that shell example to use the auto-closing |
thejpster
force-pushed
the
interior-mutability
branch
from
6caee8d to
2b5a863
Compare
Member
Author
|
Rebased again 😢 Make small PRs, they said. It's easier to review, they said. |
thejpster
force-pushed
the
interior-mutability
branch
2 times, most recently
from
f29b9f7 to
f6eb622
Compare
Contributor
Don't worry. It is easier to review! |
jannic
previously approved these changes
Oct 11, 2024
Member
Author
|
I wonder if I should turn off the thing that dismisses reviews as stale when a commit is added. |
Now we can open multiple files at once, we don't need to be so careful in our tree code.
Makes clippy happy
thejpster
force-pushed
the
interior-mutability
branch
from
f6eb622 to
d2039d4
Compare
Member
Author
|
OK, all rebased and notes added about double locking. I think this monster is good to go. |
jannic
approved these changes
Oct 12, 2024
This was referenced Oct 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VolumeManager now contains a RefCell, so all the methods can be
&self. This also means you can have multiple smart handles usable at the same time.Note that VolumeManager is !Sync, so this is just about having multiple
Fileobjects active at one time.Closes #79 (finally!)