Use chunks_exact and remove 'reason' from BlockDevice API #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The caller of the API should do their own logging. Also, we didn't have it on write and the asymmetry was displeasing.
jannic
previously approved these changes
Oct 11, 2024
|
Needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean ups in the EuroRust 2024 impl room.
) Removed the reason field from the Block Device API. It didn't get used much and the caller can just do the logging. We didn't even log writes and they're more important.
) Addeded trace logging for reads/writes.
) Use chunks_exact to simplfy some loops