Don't run cargo metadata for tools that don't need it
#167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never use anything other than the workspace members and the `target` field. Don't collect unnecessary info. As a side effect, this causes cargo-binutils to work even with very old versions of Cargo that use `resolver = "1"` by default.
We need metadata in the following cases: - If we are building a tool from source - If this is cargo-objdump and we are parsing the target in order to forward it to llvm-objdump In all other cases, we don't need metadat and we can simply avoid collecting it. Do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need metadata in the following cases:
forward it to llvm-objdump
In all other cases, we don't need metadata and we can simply avoid
collecting it. Do so.
For convenience and to avoid rebase conflicts, this is written on top of #166. Happy to separate it out if desired.