-
Notifications
You must be signed in to change notification settings - Fork 4
import project #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e6d5d5 to
949e431
Compare
949e431 to
69fda39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know if you need more docs here or somewhere else.
4a6c4ab to
dd0483e
Compare
| @@ -0,0 +1,19 @@ | |||
| name: "crates-io-auth-action" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the name used in the RFC. Is it fine or you have a better name in mind?
dd0483e to
7fe57b5
Compare
README.md
Outdated
| with: | ||
| url: my-registry.example.com | ||
| ``` | ||
| Note that the registry must support OpenID Connect authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the RFC we explicitly didn't want to make this part of the offical generic registry API protocol, so we might want to restrict this to staging.crates.io for now. if this happens to work with other registries too, then that's fine, but I'm not sure if we want to officially support that. if we want this to be truly generic then crates-io-auth-action might be the wrong name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rephrased this 👍
77ed45c to
251bd13
Compare
18fddaa to
64c6590
Compare
715a335 to
7ab08b5
Compare
7ab08b5 to
d18b87e
Compare
|
This morning I tried preventing issues like the one above from happening again, and also to reduce the size of the I'm merging this now and creating a |

Based on https://github.com/marcoieni/trusted-publishing-action-draft
Docs are in README.md and CONTRIBUTING.md