Update `diagnostics::do_not_recommend` to use the attribute template#1894

ehuss wants to merge 6 commits intorust-lang:masterrust-lang/reference:masterfrom

ehuss:do_not_recommendehuss/reference:do_not_recommendCopy head branch name to clipboard