Fix empty closure completion analysis #20811
Conversation
Example
---
```rust
fn foo() {
bar(|| $0);
}
fn bar(f: impl FnOnce() -> u32) {}
```
**Before this PR**:
```
ty: impl FnOnce() -> u32, name: ?
```
**After this PR**:
```
ty: u32, name: ?
```
rustbot
added
the
S-waiting-on-review
| .unwrap_or((None, None)) | ||
| }, | ||
| ast::ParamList(_) => (None, None), | ||
| ast::ParamList(it) => { |
There was a problem hiding this comment.
Why is it inside a ParamList? Couldn't this degrade completions for some other cases?
There was a problem hiding this comment.
Why is it inside a
ParamList?
When completing || $0, the token is | and token.parent() is the ParamList
Couldn't this degrade completions for some other cases?
The difference should only be when ParamList is used as a closure parameter, because .and_then(ast::ClosureExpr::cast)
There was a problem hiding this comment.
But won't it also trigger when inside the param list, e.g. |$0| ...?
There was a problem hiding this comment.
But won't it also trigger when inside the param list, e.g.
|$0| ...?
Will expected_type_and_name be called when completing this case?
rustbot
removed
the
S-waiting-on-review
|
Sorry, there was a problem with rebase. Please move to step #20824 |
3 participants
Example
Before this PR:
After this PR: