Bump ui_test #13368
Merged
Bump ui_test #13368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
oli-obk
commented
Sep 7, 2024
Comment on lines
-85
to
+86
| /// Nested mod //~ ERROR: item has both inner and outer attributes | ||
| /// Nested mod | ||
| //~^ ERROR: item has both inner and outer attributes |
There was a problem hiding this comment.
you can't have annotations inside other comments anymore.
oli-obk
force-pushed
the
bump_ui_test
branch
2 times, most recently
from
f58089f to
78a7847
Compare
|
Test failing |
oli-obk
force-pushed
the
bump_ui_test
branch
from
78a7847 to
1f13633
Compare
|
Everything works now |
|
Alex is currently busy I think, so jumping in. r? @flip1995 |
|
Thanks! @bors r+ |
bors
added a commit
that referenced
this pull request
Sep 10, 2024
Bump ui_test This should give a bunch of ui improvements when lots of tests are running. Please lmk of any issues with it. Switching to `--quiet` should always avoid any issues, so there's a workaround if anything crops up. Also please check that this does not regress performance for you. It doesn't for me, but that doesn't mean much.
|
💔 Test failed - checks-action_test |
|
@bors retry (changelog missing) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give a bunch of ui improvements when lots of tests are running. Please lmk of any issues with it. Switching to
--quietshould always avoid any issues, so there's a workaround if anything crops up. Also please check that this does not regress performance for you. It doesn't for me, but that doesn't mean much.changelog: none