Clarify example for type_complexity
#13392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
lukaslueg
reviewed
Sep 13, 2024
clippy_lints/src/types/mod.rs
Outdated
| /// ### Example | ||
| /// ```no_run | ||
| /// # use std::rc::Rc; | ||
| /// type InnerType = Vec<Vec<Box<(u32, u32, u32, u32)>>>; |
There was a problem hiding this comment.
Nit: The example could be even more helpful if the types were named by what they supposedly represent, instead of having purely technical names. PointMatrix (or whatever) instead of InnerType, and SharedPointMatrix instead of RcInnerType. Then let shared_matrix: SharedPointMatrix = Rc::new(inner_data).
alex-semenyuk
force-pushed
the
doc_type_complexity
branch
from
9392541 to
bc7d323
Compare
|
r? clippy |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned #13387 it's not clear how to fix issue with complexity so add example for this
changelog: none