Skip to content

fix: Specifying reason in expect(clippy::needless_return) no longer triggers false positive #13393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: Specifying reason in expect(clippy::needless_return) no longer triggers false positive #13393

merged 1 commit into from
Sep 25, 2024

Conversation

@vHugoObject
Copy link
Contributor

@vHugoObject vHugoObject commented Sep 13, 2024 •
edited
Loading

fixes #13366
changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2024
alex-semenyuk
alex-semenyuk reviewed Sep 17, 2024
View reviewed changes
@vHugoObject
fix: Specifying reason in expect(clippy::needless_return) no longer t…
ae5f857 
…riggers false positive

chore: Moved new tests into needless_return.rs

chore: Ran cargo uibless

Initial commit
@vHugoObject
Copy link
Contributor Author

@Alexendoo

@Alexendoo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 25, 2024

📌 Commit ae5f857 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 25, 2024

⌛ Testing commit ae5f857 with merge 2a61f59...

@bors
Copy link
Contributor

bors commented Sep 25, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 2a61f59 to master...

@bors bors merged commit 2a61f59 into rust-lang:master Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

+1 more reviewer

@alex-semenyuk alex-semenyuk alex-semenyuk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Alexendoo Alexendoo

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Specifying reason in expect(clippy::needless_return) triggers false positive "this lint expectation is unfulfilled"

5 participants

@vHugoObject @rustbot @Alexendoo @bors @alex-semenyuk