Skip to content

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Sep 24, 2024

changelog: none

Required for using Node.js 20.x in CI

Example warning: https://github.com/rust-lang/rust-clippy/actions/runs/11003847751

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3.

@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 24, 2024
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Sep 24, 2024

📌 Commit f7b940a has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 24, 2024

⌛ Testing commit f7b940a with merge 26e1660...

@bors
Copy link
Contributor

bors commented Sep 24, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 26e1660 to master...

@bors bors merged commit 26e1660 into rust-lang:master Sep 24, 2024
@trivikr trivikr deleted the actions/setup-node@v4 branch September 24, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants