Add lint for publically constructable Unsafe types
#13664
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
GnomedDev
force-pushed
the
public-unsafe-token
branch
from
a4ff175 to
0743df2
Compare
|
I just got the suggestion to change this from linting based on type name to linting if the only function constructors are unsafe, which sounds like a better idea. |
Alexendoo
added
S-waiting-on-author
|
☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ping @GnomedDev from triage. Do you plan to return to working on this? |
|
No, anyone can take it on if they feel like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty dangerous mistake that I feel like is really easy to run into with this pattern, and someone did recently on the Rust community discord (although with
Unprotectedinstead ofUnsafe), so let's get this linted against.changelog: [
constructable_unsafe_type]: Add lint for publically constructableUnsafetypes