Skip to content

Conversation

@alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented May 19, 2025

Close #14836

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 19, 2025
@alex-semenyuk alex-semenyuk marked this pull request as draft May 19, 2025 07:58
@alex-semenyuk alex-semenyuk changed the title Add allow-invalid configuration option for disallowed_* to the documentation [WIP] Add allow-invalid configuration option for disallowed_* to the documentation May 19, 2025
@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch 6 times, most recently from c84f1f9 to 9b3dcd2 Compare May 19, 2025 08:48
@alex-semenyuk alex-semenyuk changed the title [WIP] Add allow-invalid configuration option for disallowed_* to the documentation Add allow-invalid configuration option for disallowed_* to the documentation May 19, 2025
@alex-semenyuk alex-semenyuk marked this pull request as ready for review May 19, 2025 08:53
@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch 4 times, most recently from 3ba020f to 4524d7d Compare May 19, 2025 21:08
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some nitpicking about the formatting.

@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch 3 times, most recently from 234c3e3 to 9cb8856 Compare May 19, 2025 21:33
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more formatting nitpicking, otherwise it looks good to me. I'll let @flip1995 have the final word though.

@alex-semenyuk alex-semenyuk force-pushed the add_info_allow_invalid branch from 9cb8856 to 0bac1ca Compare May 20, 2025 04:22
@alex-semenyuk
Copy link
Member Author

@flip1995 any ideas what can be improved, thanks

@alex-semenyuk
Copy link
Member Author

@rustbot r? clippy

@rustbot rustbot assigned Centri3 and unassigned flip1995 Jun 17, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Jun 17, 2025
@samueltardieu
Copy link
Member

Thanks.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merged via the queue into rust-lang:master with commit 19c1c70 Jun 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow-invalid configuration option for disallowed_* is missing from the documentation

5 participants