Skip to content

chore(lints): move excessive_nesting to pedantic group (#14923) #14941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore(lints): move excessive_nesting to pedantic group (#14923) #14941

wants to merge 2 commits into from

Conversation

@krikera
Copy link
Contributor

@krikera krikera commented May 31, 2025 •
edited by rustbot
Loading

changelog: [excessive_nesting]: moved to pedantic group and changed default threshold from 0 to 6

This PR moves the excessive_nesting lint to the pedantic group and adjusts its default threshold from 0 to 6 to make it more practical and less noisy. The changes include:

  • Moving the lint to the pedantic group
  • Setting default threshold to 6
  • Adding UI tests for the default behavior
  • Updating documentation to reflect the new default value

fixes #14923

@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please remove them as they will spam the issue with references to the commit.

@krikera krikera closed this May 31, 2025
@krikera krikera deleted the dev/moved-excessive-nesting-to-pedantic branch May 31, 2025 17:52
Centri3
Centri3 reviewed Jun 1, 2025
View reviewed changes
clippy_lints/src/lib.rs
pub mod deprecated_lints;

// begin lints modules, do not remove this comment, it’s used in `update_lints`
// begin lints modules, do not remove this comment, it's used in `update_lints`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the corresponding text in update_lints if you wanna do this. Though it should be in a separate PR.

@krikera krikera restored the dev/moved-excessive-nesting-to-pedantic branch June 1, 2025 09:15
@krikera krikera deleted the dev/moved-excessive-nesting-to-pedantic branch June 1, 2025 12:42
@krikera krikera mentioned this pull request Jun 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Centri3 Centri3 Centri3 left review comments

Assignees

@Alexendoo Alexendoo

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move excessive_nesting to pedantic

4 participants

@krikera @rustbot @Centri3 @Alexendoo