Use interned strings when possible, for efficiency purposes #14963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, a number of unnecessary `.as_str()` calls have been removed for clarity.
rustbot
added
the
S-waiting-on-review
|
Wow, I read through the whole thing. Merging this will likely lead to quite some conflicts, but we'll have to tackle that sooner or later anyway. So I will be the bad guy to merge this. 👹 |
|
@llogiq The changes are all quite localized, I don't expect many conflicts with existing PRs even though the PR touches several files. For example, none of my pending PRs seem to have been affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, a number of unnecessary
.as_str()calls have been removed for clarity.changelog: none