Suggest naming types before using explicit type names #14996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
Member
Author
|
r? clippy |
blyxyas
requested changes
Aug 18, 2025
Member
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
What do you think about this improvement? If the transmute argument is something like x, it doesn't make that much sense calling it "the origin type" and not just mentioning x
rustbot
added
S-waiting-on-author
samueltardieu
force-pushed
the
issue-14984
branch
from
87bd829 to
77eda2d
Compare
rustbot
added
S-waiting-on-review
Member
Author
Good idea. I've credited you in the commit message as well. |
samueltardieu
force-pushed
the
issue-14984
branch
from
77eda2d to
1e85800
Compare
blyxyas
approved these changes
Aug 24, 2025
Member
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
Small stylistic change and this is ready for merge.
`missing_transmute_annotations` will suggest naming the origin and destination types if they do not have explicit names already. Co-authored-by: Alejandra González <[email protected]>
samueltardieu
force-pushed
the
issue-14984
branch
from
1e85800 to
a7ff2b0
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing_transmute_annotationswill suggest naming the origin and destination types if they do not have explicit names already.changelog: [
missing_transmute_annotations]: suggest giving origin and destination types a name in order to ascribe thetransmutecallFixes #14984