Skip to content

Simplify clippy lints page further #15208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Simplify clippy lints page further #15208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions util/gh-pages/index_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ <h1>Clippy Lints <span id="lint-count" class="badge"></span></h1> {# #}
<label for="label-{{lint.id}}"> {# #}
<h2 class="lint-title"> {# #}
<div class="panel-title-name" id="lint-{{lint.id}}"> {# #}
<span>{{lint.id}}</span> {#+ #}
<a href="#{{lint.id}}" class="lint-anchor anchor label label-default">&para;</a> {#+ #}
{{lint.id +}}
<a href="#{{lint.id}}" class="anchor label label-default">&para;</a> {#+ #}
<a href="" class="copy-to-clipboard anchor label label-default"> {# #}
&#128203; {# #}
</a> {# #}
Expand All @@ -170,24 +170,24 @@ <h2 class="lint-title"> {# #}
<div class="list-group-item lint-doc-md">{{Self::markdown(lint.docs)}}</div> {# #}
<div class="lint-additional-info-container">
{# Applicability #}
<div class="lint-additional-info-item"> {# #}
<span> Applicability: </span> {# #}
<div> {# #}
Applicability: {#+ #}
<span class="label label-default label-applicability">{{ lint.applicability_str() }}</span> {# #}
<a href="https://doc.rust-lang.org/nightly/nightly-rustc/rustc_lint_defs/enum.Applicability.html#variants">(?)</a> {# #}
</div>
{# Clippy version #}
<div class="lint-additional-info-item"> {# #}
<span>{% if lint.group == "deprecated" %}Deprecated{% else %} Added{% endif +%} in: </span> {# #}
<div> {# #}
{% if lint.group == "deprecated" %}Deprecated{% else %} Added{% endif +%} in: {#+ #}
<span class="label label-default label-version">{{lint.version}}</span> {# #}
</div>
{# Open related issues #}
<div class="lint-additional-info-item"> {# #}
<div> {# #}
<a href="https://github.com/rust-lang/rust-clippy/issues?q=is%3Aissue+{{lint.id}}">Related Issues</a> {# #}
</div>

{# Jump to source #}
{% if let Some(id_location) = lint.id_location %}
<div class="lint-additional-info-item"> {# #}
<div> {# #}
<a href="https://github.com/rust-lang/rust-clippy/blob/master/{{id_location}}">View Source</a> {# #}
</div>
{% endif %}
Expand Down
6 changes: 3 additions & 3 deletions util/gh-pages/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,10 +554,10 @@ function addListeners() {
return;
}

if (event.target.classList.contains("lint-anchor")) {
lintAnchor(event);
} else if (event.target.classList.contains("copy-to-clipboard")) {
if (event.target.classList.contains("copy-to-clipboard")) {
copyToClipboard(event);
} else if (event.target.classList.contains("anchor")) {
lintAnchor(event);
}
});

Expand Down
7 changes: 3 additions & 4 deletions util/gh-pages/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ div.panel div.panel-body button.open {
.lint-title .label { display: inline-block; }

.panel-title-name { flex: 1; min-width: 400px;}
.panel-title-name span { vertical-align: bottom; }

.panel .panel-title-name .anchor { display: none; }
.panel:hover .panel-title-name .anchor { display: inline;}
Expand Down Expand Up @@ -162,7 +161,7 @@ div.panel div.panel-body button.open {
display: flex;
flex-flow: column;
}
.lint-additional-info-item + .lint-additional-info-item {
.lint-additional-info-container > div + div {
border-top: 1px solid var(--theme-popup-border);
}
}
Expand All @@ -171,12 +170,12 @@ div.panel div.panel-body button.open {
display: flex;
flex-flow: row;
}
.lint-additional-info-item + .lint-additional-info-item {
.lint-additional-info-container > div + div {
border-left: 1px solid var(--theme-popup-border);
}
}

.lint-additional-info-item {
.lint-additional-info-container > div {
display: inline-flex;
min-width: 200px;
flex-grow: 1;
Expand Down
Loading