Skip to content

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Sep 6, 2025

Closes #15609

changelog: [eq_op] fix FP on literal of different form

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 6, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned flip1995 and unassigned y21 Sep 30, 2025
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I'd like to see a few more tests, for example ensuring that different style strings don't trigger the lint while identical ones will.

r? samueltardieu @rustbot author

View changes since this review

@rustbot rustbot assigned samueltardieu and unassigned flip1995 Sep 30, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eq_op false positive when statically asserting that a numeric value is equal to a byte literal
5 participants