-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix eq_op
FP on literal of different form
#15623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? clippy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I'd like to see a few more tests, for example ensuring that different style strings don't trigger the lint while identical ones will.
r? samueltardieu @rustbot author
Reminder, once the PR becomes ready for a review, use |
a04a13d
to
cd0de93
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Closes #15609
changelog: [
eq_op
] fix FP on literal of different form