Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 13, 2025

Fixes #14474

changelog: [needless_return]: FP with cfgd code after return

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@samueltardieu
Copy link
Member

@rustbot blocked by #15646

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Sep 13, 2025
@samueltardieu samueltardieu removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Sep 13, 2025
@ada4a
Copy link
Contributor Author

ada4a commented Sep 13, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 13, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Sep 13, 2025
Merged via the queue into rust-lang:master with commit 0c87db2 Sep 13, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2025
@ada4a ada4a deleted the needless_return branch September 13, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

needless_return false positive when combined with cfg'd code afterwards

3 participants