Skip to content

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Sep 17, 2025

Speeds up windows builds a bit. Should be fine in the rust repo since they ignore our cargo config IIRC.

r? flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2025

flip1995 is not on the review rotation at the moment.
They may take a while to respond.

@flip1995
Copy link
Member

r? @Alexendoo is usually the one I ask about Windows things.

Confirming that this is fine in the rust repo.

@rustbot rustbot assigned Alexendoo and unassigned flip1995 Sep 17, 2025
@Jarcho
Copy link
Contributor Author

Jarcho commented Sep 30, 2025

Ping @Alexendoo

@Alexendoo
Copy link
Member

My understanding is that the MSVC linker is pretty good, from a local test of touch src/driver.rs into cargo build it took longer with lld

@Jarcho
Copy link
Contributor Author

Jarcho commented Oct 3, 2025

Huh. Testing it again I'm now getting the same time for both. Two weeks ago lld was a full second faster, which is about twice as fast.

@Jarcho Jarcho closed this Oct 3, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants