refactor(non_canonical_impls): lint starting from impl
s
#15749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15520 (comment), with the following changes/additions:
Trait
enum for quickly filtering out irrelevant impls -- instead, check thetrait_of
basically right away:DefId
s of the relevant traits into the lint passcx.tcx.impl_trait_ref
's output for the theDefId
of the trait being implementedDefId
s, which should be very cheapself_ty
implements the other relevant trait.changelog: none
Not auto-assigning since @blyxyas and/or @Jarcho will be the ones reviewing it:
r? ghost