Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 30, 2025

Instead of calling span_lint_and_* in multiple places, call
span_lint_and_then once and then use the Diag methods.

Diff best viewed with whitespace ignored

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Instead of calling `span_lint_and_*` in multiple places, call
`span_lint_and_then` once and then use the `Diag` methods.
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Oct 1, 2025
Merged via the queue into rust-lang:master with commit 12e0c4c Oct 1, 2025
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 1, 2025
@ada4a ada4a deleted the map_identity branch October 1, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants