bootstrap: Don't pass an unused --color to compiletest
#149911
+9
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.
This logic is cargo-specific anyway, so there is no need for it to be a generally-available helper method.
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
rustbot
added
the
T-bootstrap
Collaborator
jieyouxu
approved these changes
Dec 12, 2025
Member
Author
|
@bors r=jieyouxu rollup |
Collaborator
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 12, 2025
bootstrap: Don't pass an unused `--color` to compiletest - Follow-up to rust-lang#149850 --- This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all. A follow-up commit also inlines `force_coloring_in_ci` into its only remaining caller, and updates its comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/rustdoctestsuite #149850This flag was an artifact of compiletest's old libtest-based test executor, and currently doesn't influence compiletest's output at all.
A follow-up commit also inlines
force_coloring_in_ciinto its only remaining caller, and updates its comment.