Add a sanity check in case of any duplicate nodes

[zetanumbers]

A simple check in case compiler tries to encode a dep node twice like in #141540.

Also if we'd try to mark a red node as green as it may then create a bad DepNodeIndex like in #148295.

If it prevents #141540 from emitting a faulty dep-graph.bin file via panic then it means you will be able to temporarily fix it by simply restarting cargo or rust-analyzer without cleaning up incremental cache.

[rustbot]

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[zetanumbers]

r? @petrochenkov

[petrochenkov]

r=me once CI is green

[matthiaskrgr]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 932e85d (932e85dab518166acc3fda1566172a48baad44d2, parent: 2a3a62d26e9e5badb806ac6a43bb307ff472b514)

[rust-timer]

Finished benchmarking commit (932e85d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.7%, secondary -4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-4.9%	[-4.9%, -4.9%]	1
All ❌✅ (primary)	-2.7%	[-2.7%, -2.7%]	1

Cycles

Results (secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-4.8%, -2.1%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.42s -> 471.934s (-0.10%)
Artifact size: 389.33 MiB -> 389.34 MiB (0.00%)

[matthiaskrgr]

oh interesting, I did not expect this :o

[petrochenkov]

@bors r+ rollup
(The perf diff is clearly noise.)

[bors]

📌 Commit c7b5fb5 has been approved by petrochenkov

It is now in the queue for this repository.