-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
If there are too many suggestions for malformed attribute, do not suggest them #149917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If there are too many suggestions for malformed attribute, do not suggest them #149917
Conversation
|
This PR modifies Some changes occurred in compiler/rustc_attr_parsing |
This comment has been minimized.
This comment has been minimized.
c424cd9 to
d025cde
Compare
|
r=me when CI is green |
|
@bors r+ rollup |
…-suggestions, r=JonathanBrouwer If there are too many suggestions for malformed attribute, do not suggest them Part of rust-lang#149865. This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall). Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate. r? `@JonathanBrouwer`
|
This one will likely break when put in a rollup so: @bors p=1 rollup=iffy |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3391c01 (parent) -> fa5eda1 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard fa5eda19b95201468f5b1c5c035ec2fc06fccd66 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (fa5eda1): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.663s -> 473.976s (0.07%) |
Part of #149865.
This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall).
Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate.
r? @JonathanBrouwer