-
Couldn't load subscription status.
- Fork 556
contributing: clarify when to update a branch vs avoid during review #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contributing: clarify when to update a branch vs avoid during review #2554
Conversation
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
|
r? rustc-dev-guide |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I agree this is a good change. I have a few nits about wording if it's not too much of a hassle.
52e6214 to
27c7fef
Compare
27c7fef to
d170192
Compare
Thanks for your feedback🙏, it has been modified. |
Explain when to update (merge conflicts, upstream CI breakage, maintainer request) and when not to (already-green PRs under review).
Recommend incremental commits during review; prefer squash/rebase at the end when requested.
Mention
git push --force-with-lease,a brief “what changed” note, and running local checks.Addresses #2542
Test plan:
mdbook buildsucceeds locally; visual check confirms the new guidance replaces the old prescriptive text.