fix(cli/rustup_mode): use ASCII-compatible spinner #4473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Sep 7, 2025
|
Could also adapt to whether Unicode is available if we have a good way of detecting that. |
Yup, I guess we can figure that out in another PR if possible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4388.
When reviewing #4471 (cc @FranciscoTGouveia) I realized that the spinner should also be ASCII-compatible, i.e. my previous comment on the progress bar (#4426 (comment)) applies to spinners as well.
https://stackoverflow.com/a/12305221 proposes some options that meet this criterion:
r"|/-\ "".oO@* "... and even if I decided to go with The Bar for the familiarity (personally I have been seeing that a lot on Windows since I first learnt to use a PC), but please feel free to propose other options.